Histogram size of "final" block of SDCH compressed data....

Histogram size of "final" block of SDCH compressed data.

Sample/histogram the sizes of the "final" block of SDCH compressed data.
Try to understand why there is a long tail in current distribution.

bug=1561947
r=huanr,kenmixter,openvcdiff


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7552

[Lincoln, 2009-01-05 16:17:31]

LGTM

http://codereview.chromium.org/17006/diff/1/3
File net/base/sdch_filter.cc (right):

http://codereview.chromium.org/17006/diff/1/3#newcode58
Line 58: UMA_HISTOGRAM_COUNTS(L"Sdch.Transit_Final_Block_Size",
Should this name have an _M suffix?  What does the _M suffix signify?

[jar (doing other things), 2009-01-05 18:16:22]

http://codereview.chromium.org/17006/diff/1/3
File net/base/sdch_filter.cc (right):

http://codereview.chromium.org/17006/diff/1/3#newcode58
Line 58: UMA_HISTOGRAM_COUNTS(L"Sdch.Transit_Final_Block_Size",
On 2009/01/05 16:17:31, Lincoln wrote:
> Should this name have an _M suffix?  What does the _M suffix signify?

When I have an existinig histogram name that I want to reuse with a different
granularity (often smaller or larger range), I tend to append a postfix letter
such as you suggested.  In this case, there is no previously existing name.   

The _M seen above relate to the use of "HISTOGRAM_MEDIUM_TIMES" as the range,
rather than the default range ("HISTOGRAM_TIMES").

[huanr, 2009-01-05 18:17:21]

LGTM

[jar (doing other things), 2009-01-05 18:25:21]

I adjusted the code to just histogram the late blocks, which arrive after more
than 15 seconds of delay.  Current stats suggest that 20% of the experimental
SDCH blocks do so, and I'm wondering if they are tiny fragments, or real
valuable(?) blocks.

[Lincoln, 2009-01-05 18:32:16]

LGTM

http://codereview.chromium.org/17006/diff/6/208
File net/base/sdch_filter.cc (right):

http://codereview.chromium.org/17006/diff/6/208#newcode58
Line 58: // Look at sizes of the 20% of blocks that are arrive with large
latency.
nit: s/are arrive/arrive/