This change enables Chrome to load locale information for the extension. It d...

chrome/common/extensions/extension.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #include "app/resource_bundle.h"
 #include "base/basictypes.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
@@ skipping 49 matching lines @@
 
   return false;
 }
 
 }  // namespace
 
 // static
 int Extension::id_counter_ = 0;
 
 const char Extension::kManifestFilename[] = "manifest.json";
+const char Extension::kLocaleFolder[] = "_locales";
+const char Extension::kMessagesFilename[] = "messages";

[Aaron Boodman, 2009/08/19 03:00:49]

I asked this in a previous review, but it looks to me like presently, the file
heirarchy is:

/_locales
  /en_us
    messages

Is that right? Out of curiosity, I'm wondering what other files you might think
would go in each locale folder.

 
 // A list of all the keys allowed by themes.
 static const wchar_t* kValidThemeKeys[] = {
   keys::kDescription,
   keys::kName,
   keys::kPublicKey,
   keys::kSignature,
   keys::kTheme,
   keys::kVersion,
   keys::kUpdateURL
@@ skipping 828 matching lines @@
           (pattern.scheme() != chrome::kHttpsScheme)) {
         *error = ExtensionErrorUtils::FormatErrorMessage(
             errors::kInvalidPermissionScheme, IntToString(i));
         return false;
       }
 
       host_permissions_.push_back(pattern);
     }
   }
 
+  // Initialize default locale (if present).
+  if (source.HasKey(keys::kDefaultLocale)) {
+    std::string default_locale;
+    if (!source.GetString(keys::kDefaultLocale, &default_locale)) {
+      *error = errors::kInvalidDefaultLocale;
+      return false;
+    }
+    // Normalize underscores to hyphens.
+    std::replace(default_locale.begin(), default_locale.end(), '_', '-');
+    set_default_locale(default_locale);
+  }
+
   return true;
 }
 
 std::set<FilePath> Extension::GetBrowserImages() {
   std::set<FilePath> image_paths;
 
   // extension icons
   for (std::map<int, std::string>::iterator iter = icons_.begin();
        iter != icons_.end(); ++iter) {
     image_paths.insert(FilePath::FromWStringHack(UTF8ToWide(iter->second)));
@@ skipping 48 matching lines @@
 }
 
 void Extension::SetBackgroundPageReady() {
   DCHECK(!background_url().is_empty());
   background_page_ready_ = true;
   NotificationService::current()->Notify(
       NotificationType::EXTENSION_BACKGROUND_PAGE_READY,
       Source<Extension>(this),
       NotificationService::NoDetails());
 }