Issue 1700016: Two changes to extension app icons:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1700016: Two changes to extension app icons:... (Closed)

Created:
10 years, 8 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews, ben+cc_chromium.org, Aaron Boodman

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Two changes to extension app icons: 1) When one of the mini tabs is an app (nano) tab, we now increase the margin between the mini tabs and the regular tabs by a few pixels. This is because with the large icons for nano tabs, it looks a little squished against the regular tabs in the tabstrip. 2) When dragging a nano tab within the tab strip, the background "handle" would grow to be as large as a regular tab (while dragging) due to the fact that UpdateData (that DraggedTabView calls) was not transferring the app tab bit to the new Tab. BUG=None TEST=Visual inspection. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45664

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -13 lines)			Patch
M	chrome/browser/views/tabs/dragged_tab_controller.cc	View	5 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/views/tabs/tab_renderer.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/views/tabs/tab_strip.h	View	4 chunks	+12 lines, -2 lines	0 comments	Download
M	chrome/browser/views/tabs/tab_strip.cc	View	7 chunks	+28 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages