Issue 1700: Do not shortcut cons string symbols during garbage collection....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1700: Do not shortcut cons string symbols during garbage collection.... (Closed)

Created:
12 years, 3 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Do not shortcut cons string symbols during garbage collection. Attempt to flatten cons strings when converting them to symbols so that symbols will most often be flat strings. Committed: http://code.google.com/p/v8/source/detail?r=253

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -15 lines)			Patch
M	src/mark-compact.cc	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	src/objects.cc	View	4 chunks	+12 lines, -4 lines	0 comments	Download
M	src/parser.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/property.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.  Nice catch.

Expand Messages | Collapse Messages