Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1697023: Update cpplint.py to #150:... (Closed)

Created:
10 years, 7 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
adonovan
CC:
chromium-reviews
Visibility:
Public.

Description

Update cpplint.py to #150: - Be explicit about "class Foo :\n public Bar" being wrong. - Allow snprintf(NULL, 0, ...) pattern. - Extend NOLINT syntax. - Remove NOLINT hint. - <new> is an STL header. - Use original filename for header guard when invoked by flymake. - Avoid false-positive build/include_what_you_use errors for use of classes called "string" other than STL ones. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -95 lines) Patch
M cpplint/cpplint.py View 18 chunks +161 lines, -85 lines 0 comments Download
M cpplint/cpplint_unittest.py View 7 chunks +66 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
Turns out I could skip a lot of the changes since they were google internal ...
10 years, 7 months ago (2010-04-30 20:25:40 UTC) #1
adonovan
10 years, 7 months ago (2010-04-30 20:36:46 UTC) #2
LGTM.

Thanks again.

Powered by Google App Engine
This is Rietveld 408576698