Issue 1697016: LiveEdit: clean JS sources a bit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1697016: LiveEdit: clean JS sources a bit (Closed)

Created:
10 years, 8 months ago by Peter Rybin

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+234 lines, -234 lines)			Patch
M	src/debug-debugger.js	View	1	1 chunk	+5 lines, -21 lines	0 comments	Download
M	src/liveedit-debugger.js	View		10 chunks	+224 lines, -208 lines	0 comments	Download
M	test/mjsunit/debug-liveedit-1.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/debug-liveedit-2.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/debug-liveedit-check-stack.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/debug-liveedit-patch-positions.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/debug-liveedit-patch-positions-replace.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Peter Rybin

Hi Soren Here I'm simply moving functions one level outside. The main function ApplyPatchMultiChunk was ...

10 years, 8 months ago (2010-04-28 13:17:17 UTC) #1

LGTM