Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1697015: Remove DCHECK in SimpleAppCacheSysmte::WillDestroyCurrentMessageLoop (Closed)

Created:
10 years, 8 months ago by rafaelw
Modified:
9 years, 7 months ago
Reviewers:
michaeln
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, dpranke+watch_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Remove DCHECK in SimpleAppCacheSysmte::WillDestroyCurrentMessageLoop. This was causing the test_shell to die trying to produce the extension docs. TEST=NONE BUG=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45820

Patch Set 1 #

Patch Set 2 : no html #

Patch Set 3 : pre commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M webkit/tools/test_shell/simple_appcache_system.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
rafaelw
10 years, 8 months ago (2010-04-27 23:06:23 UTC) #1
michaeln
Do you want these .html changes in this CL too? Seems like that would be ...
10 years, 8 months ago (2010-04-27 23:21:39 UTC) #2
rafaelw1
Yeah. Good call. On Tue, Apr 27, 2010 at 4:21 PM, <michaeln@chromium.org> wrote: > Do ...
10 years, 8 months ago (2010-04-27 23:22:55 UTC) #3
michaeln
10 years, 8 months ago (2010-04-27 23:24:17 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698