Issue 1696013: Makes FormatURL not strip http for view-source urls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1696013: Makes FormatURL not strip http for view-source urls. (Closed)

Created:
10 years, 8 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Visibility:
Public.

Description

Makes FormatURL not strip http for view-source urls. BUG=41874 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45702

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporated review feedback #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	net/base/net_util.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	net/base/net_util_unittest.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

10 years, 8 months ago (2010-04-27 00:45:09 UTC) #2

LGTM

http://codereview.chromium.org/1696013/diff/1/2
File net/base/net_util.cc (right):

http://codereview.chromium.org/1696013/diff/1/2#newcode744
net/base/net_util.cc:744: format_types = format_types &
~net::kFormatUrlOmitHTTP;
Nit: This is what &= was made for

http://codereview.chromium.org/1696013/diff/1/3
File net/base/net_util_unittest.cc (right):

http://codereview.chromium.org/1696013/diff/1/3#newcode1380
net/base/net_util_unittest.cc:1380: "view-source:http://a.b/c", L"en", 
net::kFormatUrlOmitAll,
Nit: extra space before net::

Expand Messages | Collapse Messages