Integrate with autotest log.

Integrate with autotest log.

[Sam Leffler, 2010-04-21 22:36:22]

are you missing similar changes for SecMat?

[neb, 2010-04-21 22:59:13]

On 2010/04/21 22:36:22, Sam Leffler wrote:
> are you missing similar changes for SecMat?

That's interesting. SecMat's control file is a copy of MatFunc control file, as
far as I can tell, modulo the name. Should we maybe roll them up in the same
directory and separate by name (i.e. s000, s001) so that we can trigger them
separately via a switch?

[Sam Leffler, 2010-04-21 23:04:11]

The directory split was intentional; these are independent suites of
tests meant to be handed to run_remote_tests.  Understand there are
also two more suites of tests coming and more tests to be added so
merging everything is going to generate a large number of files in 1
dir.

For now can we leave them in separate directories?

-Sam

On Wed, Apr 21, 2010 at 3:59 PM,  <neb@chromium.org> wrote:
> On 2010/04/21 22:36:22, Sam Leffler wrote:
>>
>> are you missing similar changes for SecMat?
>
> That's interesting. SecMat's control file is a copy of MatFunc control file,
> as
> far as I can tell, modulo the name. Should we maybe roll them up in the same
> directory and separate by name (i.e. s000, s001) so that we can trigger them
> separately via a switch?
>
>
> http://codereview.chromium.org/1696006/show
>

[seano, 2010-04-22 16:45:45]

http://codereview.chromium.org/1696006/diff/1/4
File server/site_tests/network_WiFiMatFunc/network_WiFiMatFunc.py (right):

http://codereview.chromium.org/1696006/diff/1/4#newcode33
server/site_tests/network_WiFiMatFunc/network_WiFiMatFunc.py:33: except
Exception as e:
don't use 'as', use a comma.

Also try something like:

    except error.TestFail, tfe:
      raise tfe
    except Exception, e:
      raise error.TestError(e)

[neb, 2010-04-23 18:46:00]

Fixed the exceptions too, the test now correctly reports both passes and
failures.

[seano, 2010-04-23 20:15:13]

On 2010/04/23 18:46:00, neb wrote:
> Fixed the exceptions too, the test now correctly reports both passes and
> failures.

LGTM