Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 1696004: Merge 57922 - 20100420 Justin Schuh <jschuh@chromium.org>... (Closed)

Created:
10 years, 8 months ago by jschuh
Modified:
9 years, 6 months ago
Reviewers:
jschuh
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 57922 - 20100420 Justin Schuh <jschuh@chromium.org>; Reviewed by Adam Barth. Invalid cast due to <video> inside <foreignObject> inside <svg> inside <img> https://bugs.webkit.org/show_bug.cgi?id=37331 Added a setting to enable/disable media perpage and have the SVGImage disable media for its dummy page. Also found and fixed a related bad cast in the V8 bindings (JSC had a custom wrapper for this already). Tests: media/svgasimagewithmediablocked.html BUG=40487 TBR=japhet@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45141

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -4 lines) Patch
A LayoutTests/media/svg-as-image-with-media-blocked.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/media/svg-as-image-with-media-blocked-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M WebCore/dom/make_names.pl View 5 chunks +31 lines, -4 lines 0 comments Download
M WebCore/page/Settings.h View 2 chunks +4 lines, -0 lines 0 comments Download
M WebCore/page/Settings.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M WebCore/svg/graphics/SVGImage.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jschuh
10 years, 8 months ago (2010-04-21 01:25:11 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698