Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1695002: Fix incorrect handling of global RegExp properties for nested replace-regexp-with-function. (Closed)

Created:
10 years, 8 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Søren Thygesen Gjesse, sgjesse
CC:
v8-dev
Visibility:
Public.

Description

Fix incorrect handling of global RegExp properties for nested replace-regexp-with-function.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -63 lines) Patch
M src/regexp.js View 5 chunks +9 lines, -5 lines 0 comments Download
M src/string.js View 3 chunks +53 lines, -54 lines 0 comments Download
M test/mjsunit/string-replace.js View 3 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
Smallish bugfix.
10 years, 8 months ago (2010-04-21 08:19:31 UTC) #1
Søren Thygesen Gjesse
10 years, 8 months ago (2010-04-21 08:29:17 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698