Issue 1694021: Add --bootargs option to build_image.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1694021: Add --bootargs option to build_image. (Closed)

Created:
10 years, 7 months ago by robotboy

Modified:
9 years, 7 months ago

Reviewers:
Bill Richardson, adlr, piman

CC:
chromium-os-reviews_chromium.org, dneiss, adlr

Base URL:
ssh://git@chromiumos-git/chromeos

Visibility:
Public.

Description

Add --bootargs option to build_image. This allows appending extra kernel command line parameters to the ARM kernel command line on the Voguev210 boards. BUG=None TEST=Built image

Patch Set 2 : Change command line parameter name. #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
M	src/platform/installer/chromeos-common.sh	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/scripts/build_gpt.sh	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	src/scripts/build_image	View	1	2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

adlr

LGTM w/ comments http://codereview.chromium.org/1694021/diff/1/3 File src/scripts/build_gpt.sh (right): http://codereview.chromium.org/1694021/diff/1/3#newcode24 src/scripts/build_gpt.sh:24: DEFINE_string bootargs "" \ s/bootargs/extra_arm_bootargs/? http://codereview.chromium.org/1694021/diff/1/4 ...

10 years, 7 months ago (2010-04-30 00:55:06 UTC) #2

Bill Richardson

I agree with adlr's comments, but otherwise LGTM.

10 years, 7 months ago (2010-04-30 16:24:16 UTC) #4

Done, thanks all.

Expand Messages | Collapse Messages

Issue 1694021: Add --bootargs option to build_image. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Change command line parameter name. #

Messages