Adding a configuration dialog for Pinyin input method.

chrome/browser/chromeos/options/language_pinyin_config_view.cc

+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/options/language_pinyin_config_view.h"
+
+#include "app/combobox_model.h"
+#include "app/l10n_util.h"
+#include "base/utf_string_conversions.h"
+#include "chrome/common/notification_type.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/browser/chromeos/cros/cros_library.h"
+#include "chrome/browser/chromeos/cros/language_library.h"
+#include "chrome/browser/chromeos/preferences.h"
+#include "chrome/browser/profile.h"
+#include "grit/generated_resources.h"
+#include "grit/locale_settings.h"
+#include "views/controls/button/checkbox.h"
+#include "views/controls/label.h"
+#include "views/grid_layout.h"
+#include "views/standard_layout.h"
+#include "views/window/window.h"
+
+namespace chromeos {
+
+LanguagePinyinConfigView::LanguagePinyinConfigView(Profile* profile)
+    : OptionsPageView(profile), contents_(NULL) {
+  for (size_t i = 0; i < kNumPinyinBooleanPrefs; ++i) {
+    pinyin_boolean_prefs_[i].Init(
+        kPinyinBooleanPrefs[i].pref_name, profile->GetPrefs(), this);
+    pinyin_boolean_checkboxes_[i] = NULL;
+  }
+}
+
+LanguagePinyinConfigView::~LanguagePinyinConfigView() {
+}
+
+void LanguagePinyinConfigView::ButtonPressed(
+    views::Button* sender, const views::Event& event) {

[tfarina (gmail-do not use), 2010/04/27 18:14:21]

this could be better aligned (readable), as:
...(views::Button* sender,
    const views::Event& even) {
...
}
?

+  views::Checkbox* checkbox = static_cast<views::Checkbox*>(sender);
+  const int pref_id = checkbox->tag();
+  DCHECK(pref_id >= 0 && pref_id < static_cast<int>(kNumPinyinBooleanPrefs));
+  pinyin_boolean_prefs_[pref_id].SetValue(checkbox->checked());
+}
+
+void LanguagePinyinConfigView::Layout() {
+  // Not sure why but this is needed to show contents in the dialog.
+  contents_->SetBounds(0, 0, width(), height());
+}
+
+std::wstring LanguagePinyinConfigView::GetWindowTitle() const {
+  return l10n_util::GetString(
+      IDS_OPTIONS_SETTINGS_LANGUAGES_PINYIN_SETTINGS_TITLE);
+}
+
+gfx::Size LanguagePinyinConfigView::GetPreferredSize() {
+  // TODO(satorux): Create our own localized content size once the UI is done.
+  return gfx::Size(views::Window::GetLocalizedContentsSize(
+      IDS_FONTSLANG_DIALOG_WIDTH_CHARS,
+      IDS_FONTSLANG_DIALOG_HEIGHT_LINES));
+}
+
+void LanguagePinyinConfigView::InitControlLayout() {
+  using views::ColumnSet;
+  using views::GridLayout;
+
+  contents_ = new views::View;
+  AddChildView(contents_);
+
+  GridLayout* layout = new GridLayout(contents_);
+  layout->SetInsets(kPanelVertMargin, kPanelHorizMargin,
+                    kPanelVertMargin, kPanelHorizMargin);
+  contents_->SetLayoutManager(layout);
+
+  const int kColumnSetId = 0;
+  ColumnSet* column_set = layout->AddColumnSet(kColumnSetId);
+  column_set->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0,
+                        GridLayout::USE_PREF, 0, 0);
+  column_set->AddPaddingColumn(0, kRelatedControlHorizontalSpacing);
+  column_set->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0,
+                        GridLayout::USE_PREF, 0, 0);
+
+  for (size_t i = 0; i < kNumPinyinBooleanPrefs; ++i) {
+    pinyin_boolean_checkboxes_[i] = new views::Checkbox(
+        l10n_util::GetString(kPinyinBooleanPrefs[i].message_id));
+    pinyin_boolean_checkboxes_[i]->set_listener(this);
+    pinyin_boolean_checkboxes_[i]->set_tag(i);
+  }
+  NotifyPrefChanged();
+  for (size_t i = 0; i < kNumPinyinBooleanPrefs; ++i) {
+    layout->StartRow(0, kColumnSetId);
+    layout->AddView(pinyin_boolean_checkboxes_[i]);
+  }
+}
+
+void LanguagePinyinConfigView::Observe(NotificationType type,
+                                       const NotificationSource& source,
+                                       const NotificationDetails& details) {
+  if (type == NotificationType::PREF_CHANGED) {

[tfarina (gmail-do not use), 2010/04/27 18:14:21]

chromium style is to not add {} in single line statements. :)

[satorux1, 2010/04/28 05:37:05]

Is it? Could you tell us where it is defined?

+    NotifyPrefChanged();
+  }
+}
+
+void LanguagePinyinConfigView::NotifyPrefChanged() {
+  for (size_t i = 0; i < kNumPinyinBooleanPrefs; ++i) {
+    const bool checked = pinyin_boolean_prefs_[i].GetValue();
+    pinyin_boolean_checkboxes_[i]->SetChecked(checked);
+  }
+}
+
+}  // namespace chromeos