Issue 1694016: Simplify the use of the stm instruction on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1694016: Simplify the use of the stm instruction on ARM. (Closed)

Created:
10 years, 8 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Simplify the use of the stm instruction on ARM. Committed: http://code.google.com/p/v8/source/detail?r=4501

Patch Set 1 #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -48 lines)			Patch
M	src/arm/codegen-arm.cc	View	8 chunks	+8 lines, -14 lines	0 comments	Download
M	src/arm/ic-arm.cc	View	9 chunks	+9 lines, -12 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1 chunk	+59 lines, -0 lines	1 comment	Download
M	src/arm/stub-cache-arm.cc	View	8 chunks	+10 lines, -18 lines	0 comments	Download
M	src/arm/virtual-frame-arm.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

10 years, 8 months ago (2010-04-26 14:08:15 UTC) #2

LGTM

http://codereview.chromium.org/1694016/diff/1/2
File src/arm/macro-assembler-arm.h (right):

http://codereview.chromium.org/1694016/diff/1/2#newcode102
src/arm/macro-assembler-arm.h:102: str(src1, MemOperand(sp, 4, NegPreIndex),
cond);
Why not use push (from arm-assembler) for this?

Expand Messages | Collapse Messages