Test for touchpad left and right buttons press and release.

Test for touchpad left and right buttons press and release.

Added new files for hardware touchpad test. Mostly copied hardware_KeyboardAssembly test.

BUG=469
TEST=./run_remote_tests.sh --board=$BOARD --remote=$REMOTE_IP hardware_Touchpad/control

[whywhat, 2010-04-26 14:23:23]

Darin, I wasn't sure, who's the best person to review this so replace yourself
with someone if there's more appropriate person available.

[petkov, 2010-04-26 22:20:12]

+nsander, tammo -- they're probably interested in using this test for factory
testing?

A couple of nits below.

Is this work in progress -- i.e., are you planning to test the touchpad movement
and gestures in the same test? If not, it should be renamed.

To become part of hwqual, you'd need to update the hwqual suite -- see
suite_HWQual/README.txt.

http://codereview.chromium.org/1692009/diff/1/4
File client/site_tests/hardware_Touchpad/src/TouchpadTest.py (right):

http://codereview.chromium.org/1692009/diff/1/4#newcode22
client/site_tests/hardware_Touchpad/src/TouchpadTest.py:22: import os
Sort alphabetically.

http://codereview.chromium.org/1692009/diff/1/4#newcode182
client/site_tests/hardware_Touchpad/src/TouchpadTest.py:182: touchpad_image_size
= (touchpad_image.get_width(), touchpad_image.get_height())
80 chars

[Nick Sanders, 2010-04-26 22:31:35]

Yes, this does look like it would be really useful for factory testing.

Not necessary for this CL, but our touchpad will also support multitouch,
and for both factory and hwqual we should validate that two finger events
work.

Tammo is planning to pull out the ui/X start and stop stuff into a library,
it looks like you've based this off the keyboard test so the changes there
should be pretty similar.


On Mon, Apr 26, 2010 at 3:20 PM, <petkov@chromium.org> wrote:

> +nsander, tammo -- they're probably interested in using this test for
> factory
> testing?
>
> A couple of nits below.
>
> Is this work in progress -- i.e., are you planning to test the touchpad
> movement
> and gestures in the same test? If not, it should be renamed.
>
> To become part of hwqual, you'd need to update the hwqual suite -- see
> suite_HWQual/README.txt.
>
>
>
> http://codereview.chromium.org/1692009/diff/1/4
> File client/site_tests/hardware_Touchpad/src/TouchpadTest.py (right):
>
> http://codereview.chromium.org/1692009/diff/1/4#newcode22
> client/site_tests/hardware_Touchpad/src/TouchpadTest.py:22: import os
> Sort alphabetically.
>
> http://codereview.chromium.org/1692009/diff/1/4#newcode182
> client/site_tests/hardware_Touchpad/src/TouchpadTest.py:182:
> touchpad_image_size = (touchpad_image.get_width(),
> touchpad_image.get_height())
> 80 chars
>
> http://codereview.chromium.org/1692009/show
>

[whywhat, 2010-04-27 10:26:14]

Please, take another look.
I want to expand the test in following changes.
I'm quite new to PyGTK and GTK too. Which events should I connect to in order to
get notifications about touch, multitouch and other events we need to test?

http://codereview.chromium.org/1692009/diff/1/4
File client/site_tests/hardware_Touchpad/src/TouchpadTest.py (right):

http://codereview.chromium.org/1692009/diff/1/4#newcode22
client/site_tests/hardware_Touchpad/src/TouchpadTest.py:22: import os
On 2010/04/26 22:20:13, petkov wrote:
> Sort alphabetically.
> 

Done.

http://codereview.chromium.org/1692009/diff/1/4#newcode182
client/site_tests/hardware_Touchpad/src/TouchpadTest.py:182: touchpad_image_size
= (touchpad_image.get_width(), touchpad_image.get_height())
On 2010/04/26 22:20:13, petkov wrote:
> 80 chars
> 

Done.

[Nick Sanders, 2010-04-27 21:51:41]

Can you take a look at this CL, since the factory tests currently start X, we
need to kill X on completion so the next test can start:
http://codereview.chromium.org/1784003/show


On 2010/04/27 10:26:14, whywhat wrote:
> Please, take another look.
> I want to expand the test in following changes.
> I'm quite new to PyGTK and GTK too. Which events should I connect to in order
to
> get notifications about touch, multitouch and other events we need to test?

The touchpad drivers aren't quite done yet, so the multitouch stuff isn't
implemented yet. I just mentioned it as an FYI for future support.

[whywhat, 2010-04-28 09:30:10]

Did the same thing as in issue mentioned by Nick.
Will add more features tested when we have driver support.
Is there support for pressure levels and a way to distinguish a tap from button
click? I get left button click event on tap.

[tammo-google, 2010-04-28 10:09:48]

My understanding is that real data, meaning multitouch and proper
click events, will happen with the next generation of drivers, once we
get those.

Tammo

On Wed, Apr 28, 2010 at 17:30,  <avayvod@chromium.org> wrote:
> Did the same thing as in issue mentioned by Nick.
> Will add more features tested when we have driver support.
> Is there support for pressure levels and a way to distinguish a tap from
> button
> click? I get left button click event on tap.
>
> http://codereview.chromium.org/1692009/show
>

[whywhat, 2010-04-28 12:42:24]

So, LGTM anyone?
Also, I know that png for keyboard test is stored in some internal repository.
Is it ok to push my change as it is or should I put the picture somewhere else?

[Nick Sanders, 2010-04-28 12:48:15]

lgtm
The pic should be OK in the public repository, it's pretty generic.

On Wed, Apr 28, 2010 at 5:42 AM, <avayvod@chromium.org> wrote:

> So, LGTM anyone?
> Also, I know that png for keyboard test is stored in some internal
> repository.
> Is it ok to push my change as it is or should I put the picture somewhere
> else?
>
>
> http://codereview.chromium.org/1692009/show
>