Issue 1691018: GTK: make tabbed bookmark manager compatible with more types of drops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1691018: GTK: make tabbed bookmark manager compatible with more types of drops. (Closed)

Created:
10 years, 8 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
tony, arv (Not doing code reviews)

CC:
chromium-reviews, brettw-cc_chromium.org, ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

GTK: make tabbed bookmark manager compatible with more types of drops. BUG=42466 TEST=see bug. Also, drags from firefox bookmark bar to tabbed bookmark manager should work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45778

Patch Set 1 #

Total comments: 1

Patch Set 2 : naming #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -12 lines)			Patch
M	chrome/browser/bookmarks/bookmark_drag_data.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_drag_data.cc	View	1	2 chunks	+18 lines, -7 lines	0 comments	Download
M	chrome/browser/tab_contents/web_drag_dest_gtk.cc	View	1	2 chunks	+15 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM http://codereview.chromium.org/1691018/diff/1/3 File chrome/browser/bookmarks/bookmark_drag_data.h (right): http://codereview.chromium.org/1691018/diff/1/3#newcode93 chrome/browser/bookmarks/bookmark_drag_data.h:93: void CreateFromData(const GURL& url, const string16& title); Style ...

10 years, 8 months ago (2010-04-27 03:26:52 UTC) #2

arv (Not doing code reviews)

LGTM I agree with Tony about the name of CreateFromData and ReadFromVector. I'm also a ...

10 years, 8 months ago (2010-04-27 06:52:42 UTC) #3

LGTM

Expand Messages | Collapse Messages