Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1691009: - Fix x64 build.... (Closed)

Created:
10 years, 8 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

- Fix Win64 build. - Style cleanup: use Page::is_valid() instead of NULL-check, use Heap::CreateFillerObjectAt() instead of dummy free list nodes Committed: http://code.google.com/p/v8/source/detail?r=4484

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -25 lines) Patch
M src/mark-compact.cc View 5 chunks +20 lines, -13 lines 0 comments Download
M src/spaces.h View 1 chunk +1 line, -1 line 0 comments Download
M src/spaces.cc View 4 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
10 years, 8 months ago (2010-04-23 10:49:16 UTC) #1
Mads Ager (chromium)
10 years, 8 months ago (2010-04-23 12:10:02 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698