Make NativeControl inherit from base::WindowImpl instead of CWindowImpl to re...

Make NativeControl inherit from base::WindowImpl instead of CWindowImpl to reduce a dependency on ATL.

BUG=5027
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23645

[Peter Kasting, 2009-08-14 21:24:24]

LGTM

[Peter Kasting, 2009-08-18 02:46:12]

http://codereview.chromium.org/169015/diff/2024/2028
File base/window_impl.cc (right):

http://codereview.chromium.org/169015/diff/2024/2028#newcode158
Line 158: if (message != WM_NCDESTROY)
Why can't we call DefWindowProc()?  (There should be comments here.)

http://codereview.chromium.org/169015/diff/2024/2028#newcode159
Line 159: result = DefWindowProc(hwnd_, message, w_param, l_param);
Nit: Just return the result directly

http://codereview.chromium.org/169015/diff/2024/2028#newcode162
Line 162: if (message == WM_NCDESTROY) {
Why should we do this when ProcessWindowMessage() has handled it?

[James Hawkins, 2009-08-18 18:49:49]

http://codereview.chromium.org/169015/diff/2024/2028
File base/window_impl.cc (right):

http://codereview.chromium.org/169015/diff/2024/2028#newcode158
Line 158: if (message != WM_NCDESTROY)
On 2009/08/18 02:46:12, Peter Kasting wrote:
> Why can't we call DefWindowProc()?  (There should be comments here.)

I had the idea that the hwnd would get destroyed if processed by DefWindowProc,
but I've tested and that's not the case, so I removed the check to keep it
simple.

http://codereview.chromium.org/169015/diff/2024/2028#newcode159
Line 159: result = DefWindowProc(hwnd_, message, w_param, l_param);
On 2009/08/18 02:46:12, Peter Kasting wrote:
> Nit: Just return the result directly

We can't because we have to be able to call OnFinalMessage if we get
WM_NCDESTROY.  If I leave the check in, we'd be able to return at this point,
but I think it's simpler this way.

http://codereview.chromium.org/169015/diff/2024/2028#newcode162
Line 162: if (message == WM_NCDESTROY) {
On 2009/08/18 02:46:12, Peter Kasting wrote:
> Why should we do this when ProcessWindowMessage() has handled it?

ATLs implementation of CWindowImpl provided an OnFinalMessage notification that
we depend on in a lot of places where we're replacing CWindowImpl.  It's used
for cleanup.

[Peter Kasting, 2009-08-18 18:54:30]

The new patch is much clearer.  Thanks, LGTM