Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: test/mjsunit/array-pop.js

Issue 1689010: X64: Faster push/pop implementation. (Closed)
Patch Set: Addressed review comments. Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/stub-cache-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 51
52 assertEquals(7, a.pop(), "7th pop"); 52 assertEquals(7, a.pop(), "7th pop");
53 assertEquals(0, a.length, "length 7th pop"); 53 assertEquals(0, a.length, "length 7th pop");
54 54
55 assertEquals(undefined, a.pop(), "8th pop"); 55 assertEquals(undefined, a.pop(), "8th pop");
56 assertEquals(0, a.length, "length 8th pop"); 56 assertEquals(0, a.length, "length 8th pop");
57 57
58 assertEquals(undefined, a.pop(1, 2, 3), "9th pop"); 58 assertEquals(undefined, a.pop(1, 2, 3), "9th pop");
59 assertEquals(0, a.length, "length 9th pop"); 59 assertEquals(0, a.length, "length 9th pop");
60 } 60 }
61
62 // Check that pop works on inherited properties.
63 for (var i = 0; i < 10 ;i++) { // Ensure ICs are stabilized.
64 Array.prototype[1] = 1;
65 Array.prototype[3] = 3;
66 Array.prototype[5] = 5;
67 Array.prototype[7] = 7;
68 Array.prototype[9] = 9;
69 a = [0,1,2,,4,,6,7,8,,];
70 assertEquals(10, a.length, "inherit-initial-length");
71 for (var j = 9; j >= 0; j--) {
72 assertEquals(j + 1, a.length, "inherit-pre-length-" + j);
73 assertTrue(j in a, "has property " + j);
74 var own = a.hasOwnProperty(j);
75 var inherited = Array.prototype.hasOwnProperty(j);
76 assertEquals(j, a.pop(), "inherit-pop");
77 assertEquals(j, a.length, "inherit-post-length");
78 assertFalse(a.hasOwnProperty(j), "inherit-deleted-own-" + j);
79 assertEquals(inherited, Array.prototype.hasOwnProperty(j),
80 "inherit-not-deleted-inherited" + j);
81 }
82 Array.prototype.length = 0; // Clean-up.
83 }
61 })(); 84 })();
62 85
63 // Test the case of not JSArray receiver. 86 // Test the case of not JSArray receiver.
64 // Regression test for custom call generators, see issue 684. 87 // Regression test for custom call generators, see issue 684.
65 (function() { 88 (function() {
66 var a = []; 89 var a = [];
67 for (var i = 0; i < 100; i++) a.push(i); 90 for (var i = 0; i < 100; i++) a.push(i);
68 var x = {__proto__: a}; 91 var x = {__proto__: a};
69 for (var i = 0; i < 100; i++) { 92 for (var i = 0; i < 100; i++) {
70 assertEquals(99 - i, x.pop(), i + 'th iteration'); 93 assertEquals(99 - i, x.pop(), i + 'th iteration');
71 } 94 }
72 })(); 95 })();
OLDNEW
« no previous file with comments | « src/x64/stub-cache-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698