Addressing review feedback on last changes....

Addressing review feedback on last changes.

BUG=none
TEST=none (ran converter script)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45830

[Ken Russell (switch to Gerrit), 2010-04-28 02:35:15]

Please review. Thanks.

[Alexey Marinichev, 2010-04-28 17:03:00]

http://codereview.chromium.org/1687015/diff/1/2
File cg_to_glsl/convert.py (right):

http://codereview.chromium.org/1687015/diff/1/2#newcode61
cg_to_glsl/convert.py:61: exes = [os.path.join(cg_root, 'linux', 'bin', 'cgc'),
I just think it's ugly.  I don't think there are platforms on which cgc can run
whose path separator is not slash.

I also still think that os.path.join should be moved inside the for loop.

[Ken Russell (switch to Gerrit), 2010-04-28 17:38:09]

http://codereview.chromium.org/1687015/diff/1/2
File cg_to_glsl/convert.py (right):

http://codereview.chromium.org/1687015/diff/1/2#newcode61
cg_to_glsl/convert.py:61: exes = [os.path.join(cg_root, 'linux', 'bin', 'cgc'),
On 2010/04/28 17:03:00, Alexey Marinichev wrote:
> I just think it's ugly.  I don't think there are platforms on which cgc can
run
> whose path separator is not slash.
> 
> I also still think that os.path.join should be moved inside the for loop.

OK, I've changed this and retested with the two versions of Python on Windows as
well as on the Mac. There was a bug below (needed to check the return code of
subprocess.call -- I had previously been using check_call, which isn't supported
in Python 2.4) which has also been fixed.

[Alexey Marinichev, 2010-04-28 17:54:29]

LGTM