Issue 1687013: Fix search-for-string and replace global to avoid hangs...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1687013: Fix search-for-string and replace global to avoid hangs... (Closed)

Created:
10 years, 8 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix search-for-string and replace global to avoid hangs and spurious exceptions. Committed: http://code.google.com/p/v8/source/detail?r=4511

Patch Set 1 #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -9 lines)			Patch
	M	src/runtime.cc	View		2 chunks	+8 lines, -9 lines	1 comment	Download
	A	test/mjsunit/search-string-multiple.js	View		1 chunk	+62 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

10 years, 8 months ago (2010-04-27 11:22:47 UTC) #2

LGTM

http://codereview.chromium.org/1687013/diff/1/2
File src/runtime.cc (right):

http://codereview.chromium.org/1687013/diff/1/2#newcode3200
src/runtime.cc:3200: ReplacementStringBuilder::AddSubjectSlice(builder,
match_end, new_pos);
Long line.

Expand Messages | Collapse Messages