Issue 1687004: Prepare push of version 2.2.4 to trunk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1687004: Prepare push of version 2.2.4 to trunk. (Closed)

Created:
10 years, 8 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Prepare push of version 2.2.4 to trunk. Committed: http://code.google.com/p/v8/source/detail?r=4451

Patch Set 2 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	ChangeLog	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/1687004/diff/1/3 File ChangeLog (right): http://codereview.chromium.org/1687004/diff/1/3#newcode5 ChangeLog:5: Load ICs for nonexistent properties, fixing issue 675. ...

10 years, 8 months ago (2010-04-21 07:03:37 UTC) #2

Rico

10 years, 8 months ago (2010-04-21 07:09:47 UTC) #3

http://codereview.chromium.org/1687004/diff/1/3
File ChangeLog (right):

http://codereview.chromium.org/1687004/diff/1/3#newcode5
ChangeLog:5: Load ICs for nonexistent properties, fixing issue 675.
On 2010/04/21 07:03:37, Mads Ager wrote:
> I would remove this.  Issue 675 was not in the latest version so the new Load
> ICs is just a perf improvement.

Done.

http://codereview.chromium.org/1687004/diff/1/3#newcode7
ChangeLog:7: Introduce fast native caches and use it in String.search.
On 2010/04/21 07:03:37, Mads Ager wrote:
> Ditto.

Done.

Expand Messages | Collapse Messages

Issue 1687004: Prepare push of version 2.2.4 to trunk. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages