test/cctest/test-heap.cc - Issue 1683001: Put empty pages discovered during sweeping to the end of the list of pages...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap.cc

Issue 1683001: Put empty pages discovered during sweeping to the end of the list of pages... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-heap.cc

===================================================================

--- test/cctest/test-heap.cc (revision 4449)

+++ test/cctest/test-heap.cc (working copy)

@@ -830,11 +830,11 @@

}

CHECK(bytes_to_page > FixedArray::kHeaderSize);

- int* is_normal_page_ptr = &Page::FromAddress(next_page)->is_normal_page;

- Address is_normal_page_addr = reinterpret_cast<Address>(is_normal_page_ptr);

+ intptr_t* flags_ptr = &Page::FromAddress(next_page)->flags;

+ Address flags_addr = reinterpret_cast<Address>(flags_ptr);

int bytes_to_allocate =

- static_cast<int>(is_normal_page_addr - current_top) + kPointerSize;

+ static_cast<int>(flags_addr - current_top) + kPointerSize;

int n_elements = (bytes_to_allocate - FixedArray::kHeaderSize) /

kPointerSize;

@@ -843,7 +843,7 @@

Heap::AllocateFixedArray(n_elements));

int index = n_elements - 1;

- CHECK_EQ(is_normal_page_ptr,

+ CHECK_EQ(flags_ptr,

HeapObject::RawField(array, FixedArray::OffsetOfElementAt(index)));

array->set(index, Smi::FromInt(0));

// This chould have turned next page into LargeObjectPage:

« no previous file with comments | « src/spaces-inl.h ('k') | test/cctest/test-spaces.cc » ('j') | no next file with comments »