Issue 1681: Make CreateDirectory consistent on Win and Posix when directory exists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1681: Make CreateDirectory consistent on Win and Posix when directory exists. (Closed)

Created:
12 years, 3 months ago by Michael Moss

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Make CreateDirectory consistent on Win and Posix when directory exists. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1941

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	base/file_util.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	base/file_util_win.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

M-A Ruel

12 years, 3 months ago (2008-09-09 22:28:59 UTC) #2

Yep, it'll return true on files while it should return false. That's fine for
now (build break).