Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Unified Diff: chrome/browser/extensions/extension_protocol_unittest.cc

Issue 16805: Move Contains() method to file_utils, stop relying on in extensions_protocol (Closed)
Patch Set: Review feedback Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_protocol_unittest.cc
diff --git a/chrome/browser/extensions/extension_protocol_unittest.cc b/chrome/browser/extensions/extension_protocol_unittest.cc
index 1d2b4f22c33a098255e25cade191ca1aeb2a0193..e23658df023a1a17d8ed082bd5fd296be6619391 100644
--- a/chrome/browser/extensions/extension_protocol_unittest.cc
+++ b/chrome/browser/extensions/extension_protocol_unittest.cc
@@ -15,12 +15,8 @@ TEST(ExtensionProtocolTest, GetPathForExtensionResource) {
GetPathForExtensionResource(extension_path, "/foo/bar.gif").value());
EXPECT_EQ(std::wstring(L"C:\\myextension\\"),
GetPathForExtensionResource(extension_path, "/").value());
- // TODO(aa): This one is a bit weird, but is what net::FileURLToFilePath()
- // returns for this input. Investigate adding more validation.
EXPECT_EQ(std::wstring(L"C:\\myextension\\c:\\foo.gif"),
GetPathForExtensionResource(extension_path, "/c:/foo.gif").value());
- EXPECT_EQ(std::wstring(L"C:\\myextension\\foo.gif"),
- GetPathForExtensionResource(extension_path, "//foo.gif").value());
EXPECT_EQ(std::wstring(L""),
GetPathForExtensionResource(extension_path, "/../foo.gif").value());
#else
@@ -29,8 +25,6 @@ TEST(ExtensionProtocolTest, GetPathForExtensionResource) {
GetPathForExtensionResource(extension_path, "/foo/bar.gif").value());
EXPECT_EQ(std::wstring("/myextension/"),
GetPathForExtensionResource(extension_path, "/").value());
- EXPECT_EQ(std::wstring("/myextension/foo.gif"),
- GetPathForExtensionResource(extension_path, "//foo.gif").value());
EXPECT_EQ(std::wstring(""),
GetPathForExtensionResource(extension_path, "/../foo.gif").value());
#endif
« base/file_util_unittest.cc ('K') | « chrome/browser/extensions/extension_protocol.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698