Move Contains() method to file_utils, stop relying on in extensions_protocol

base/file_util.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 
 #include <stdio.h>
 
 #include <fstream>
 
@@ skipping 258 matching lines @@
   *file_size = info.size;
   return true;
 }
 
 bool CloseFile(FILE* file) {
   if (file == NULL)
     return true;
   return fclose(file) == 0;
 }
 
+bool ContainsPath(const FilePath &parent, const FilePath& child) {
+  FilePath abs_parent = FilePath(parent);
+  FilePath abs_child = FilePath(child);
+
+  if (!file_util::AbsolutePath(&abs_parent) ||
+      !file_util::AbsolutePath(&abs_child))
+    return false;
+
+#if defined(OS_WIN)
+  // file_util::AbsolutePath() does not flatten case on Windows, so we must do
+  // a case-insensitive compare.
+  if (!StartsWith(abs_child.value(), abs_parent.value(), false))
+#else

[Erik does not do reviews, 2009/01/12 17:14:05]

#else if defined(OS_POSIX)

+  if (!StartsWithASCII(abs_child.value(), abs_parent.value(), true))

[Erik does not do reviews, 2009/01/12 17:14:05]

Put a comment / TODO / bug in here to reference the MacOS case sensitivity
issue.  Since this is in file_util, it seems like we could fall back to a test
that actually touches the filesystem in some way when StartsWithASCII returns
false.

+#endif
+    return false;
+
+  // file_util::AbsolutePath() normalizes '/' to '\' on Windows, so we only need
+  // to check kSeparators[0].
+  if (abs_child.value().length() <= abs_parent.value().length() ||
+      abs_child.value()[abs_parent.value().length()] !=
+          FilePath::kSeparators[0])
+    return false;
+
+  return true;
+}
+
 ///////////////////////////////////////////////
 // MemoryMappedFile
 
 MemoryMappedFile::~MemoryMappedFile() {
   CloseHandles();
 }
 
 bool MemoryMappedFile::Initialize(const FilePath& file_name) {
   if (IsValid())
     return false;
@@ skipping 150 matching lines @@
   FilePath directory = path.DirName();
   // If there is no separator, we will get back kCurrentDirectory.
   // In this case, clear dir.
   if (directory == path || directory.value() == FilePath::kCurrentDirectory)
     dir->clear();
   else
     *dir = directory.ToWStringHack();
 }
 }  // namespace