Issue 1672006: Support multi-chunk differences

Issue 1672006: Support multi-chunk differences (Closed)

Created:
10 years, 8 months ago by Peter Rybin

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Support multi-chunk differences Committed: http://code.google.com/p/v8/source/detail?r=4467

Patch Set 3 : comment and clean #

Patch Set 6 : follow codereview #

Patch Set 7 : merge #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+471 lines, -157 lines)			Patch
M	src/liveedit.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/liveedit.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/liveedit-debugger.js	View	1 2 3 4 5	8 chunks	+440 lines, -147 lines	0 comments	Download
M	src/runtime.cc	View	1 2 3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/debug-liveedit-newsource.js	View	1 2 3 4 5	1 chunk	+24 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Rybin

Hi Soren Here I am extending algorithm so that changes when user modifies script in ...

10 years, 8 months ago (2010-04-20 22:53:43 UTC) #1

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/1672006/diff/9001/10001 File src/liveedit-debugger.js (right): http://codereview.chromium.org/1672006/diff/9001/10001#newcode50 src/liveedit-debugger.js:50: // This API is a legacy and is ...

10 years, 8 months ago (2010-04-21 13:41:52 UTC) #2

Peter Rybin

10 years, 8 months ago (2010-04-21 16:58:18 UTC) #3

http://codereview.chromium.org/1672006/diff/9001/10001
File src/liveedit-debugger.js (right):

http://codereview.chromium.org/1672006/diff/9001/10001#newcode50
src/liveedit-debugger.js:50: // This API is a legacy and is obsolete.
On 2010/04/21 13:41:53, Søren Gjesse wrote:
> Why not remove it then?

I will do it soon. It is still used in several places.

http://codereview.chromium.org/1672006/diff/9001/10001#newcode541
src/liveedit-debugger.js:541: info_node.new_end_pos =
chunk_it.TranslatePos(info_node.info.end_position);
On 2010/04/21 13:41:53, Søren Gjesse wrote:
> Long line.

Done.

http://codereview.chromium.org/1672006/diff/9001/10005
File test/mjsunit/debug-liveedit-newsource.js (right):

http://codereview.chromium.org/1672006/diff/9001/10005#newcode64
test/mjsunit/debug-liveedit-newsource.js:64: assertEquals(25, something1);
On 2010/04/21 13:41:53, Søren Gjesse wrote:
> Maybe add a comment to why this is not 26.

Done.

Expand Messages | Collapse Messages