Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1667003: Disable the following net tests for ChromeFrame as they rely on functionality... (Closed)

Created:
10 years, 8 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, amit
Visibility:
Public.

Description

Disable the following net tests for ChromeFrame as they rely on functionality provided by Chrome's network stack like the ability to override a proxy for a URL request, etc. 1. URLRequestTestHTTP.ProxyTunnelRedirectTest 2.URLRequestTestHTTP.UnexpectedServerAuthTest. TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome_frame/test/net/fake_external_tab.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
10 years, 8 months ago (2010-04-16 21:22:33 UTC) #1
amit
10 years, 8 months ago (2010-04-16 21:28:37 UTC) #2
OK, thanks for investigating this.

On Fri, Apr 16, 2010 at 2:22 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Disable the following net tests for ChromeFrame as they rely on
> functionality
> provided by Chrome's network stack
> like the ability to override a proxy for a URL request, etc.
>
> 1. URLRequestTestHTTP.ProxyTunnelRedirectTest
> 2.URLRequestTestHTTP.UnexpectedServerAuthTest.
>
> TBR=amit
>
>
> Please review this at http://codereview.chromium.org/1667003/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/net/fake_external_tab.cc
>
>
> Index: chrome_frame/test/net/fake_external_tab.cc
> ===================================================================
> --- chrome_frame/test/net/fake_external_tab.cc  (revision 44708)
> +++ chrome_frame/test/net/fake_external_tab.cc  (working copy)
> @@ -440,6 +440,11 @@
>     "URLRequestTest.DoNotSendCookies_ViaPolicy_Async",
>     "URLRequestTest.CancelTest_During_OnGetCookiesBlocked",
>     "URLRequestTest.CancelTest_During_OnSetCookieBlocked",
> +
> +    // These tests are disabled as the rely on functionality provided by
> +    // Chrome's HTTP stack like the ability to set the proxy for a URL,
> etc.
> +    "URLRequestTestHTTP.ProxyTunnelRedirectTest",
> +    "URLRequestTestHTTP.UnexpectedServerAuthTest",
>   };
>
>   std::string filter("-");  // All following filters will be negative.
>
>
>

Powered by Google App Engine
This is Rietveld 408576698