Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: src/platform/vboot_reference/vfirmware/firmware_image_fw.c

Issue 1665007: Fix bug in GetLogicalFirmwareVersion(). (Closed)
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/platform/vboot_reference/vfirmware/firmware_image_fw.c
diff --git a/src/platform/vboot_reference/vfirmware/firmware_image_fw.c b/src/platform/vboot_reference/vfirmware/firmware_image_fw.c
index 1cd5af9f361526fd3ea83180449b8332f6d7af56..85b4d352c508c12d39ec0805b688567dc507933f 100644
--- a/src/platform/vboot_reference/vfirmware/firmware_image_fw.c
+++ b/src/platform/vboot_reference/vfirmware/firmware_image_fw.c
@@ -230,6 +230,7 @@ uint32_t GetLogicalFirmwareVersion(uint8_t* verification_header_blob) {
Memcpy(&firmware_version,
verification_header_blob + (FIELD_LEN(magic) + /* Offset to field. */
FIELD_LEN(header_len) +
+ FIELD_LEN(firmware_sign_algorithm) +
FIELD_LEN(firmware_key_version) +
firmware_sign_key_len +
FIELD_LEN(header_checksum) +
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698