Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1665005: Linux: Make TCMalloc override ptmalloc hooks. (Closed)

Created:
10 years, 8 months ago by willchan no longer on Chromium
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Alexander Potapenko
Visibility:
Public.

Description

Linux: Make TCMalloc override ptmalloc hooks. Certain libraries still seem to fall through to ptmalloc. At least one cause seems to be because some libraries dynamically load other libraries via dlopen() invoked with RTLD_DEEPBIND. Therefore, we override ptmalloc's hooks to pass through to TCMalloc. This is suboptimal since it adds an extra function call per malloc()/realloc()/free()/memalign() invocation, but it should catch all cases where the library does not correctly allow for malloc implementation overrides. BUG=38692 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44975

Patch Set 1 #

Patch Set 2 : Update change to new location. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M third_party/tcmalloc/chromium/src/tcmalloc.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
Yes this works, but the change needs to go into the same spot in tcmalloc.cc ...
10 years, 8 months ago (2010-04-19 21:02:15 UTC) #1
willchan no longer on Chromium
Updated to tcmalloc.cc. Added glider to cc.
10 years, 8 months ago (2010-04-19 22:17:47 UTC) #2
Lei Zhang
10 years, 8 months ago (2010-04-19 22:24:58 UTC) #3
LGTM

FYI, this does not fix http://crbug.com/40974

Powered by Google App Engine
This is Rietveld 408576698