Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1362)

Side by Side Diff: views/view_unittest.cc

Issue 1664001: Fixes possible crash if the window hosting a menu was closed while the (Closed)
Patch Set: Incorporated review feedback Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « views/controls/menu/submenu_view.cc ('k') | views/views.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <map> 5 #include <map>
6 6
7 #include "app/clipboard/clipboard.h" 7 #include "app/clipboard/clipboard.h"
8 #include "base/keyboard_codes.h" 8 #include "base/keyboard_codes.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
(...skipping 669 matching lines...) Expand 10 before | Expand all | Expand 10 after
680 gfx::Rect* bounds) const { 680 gfx::Rect* bounds) const {
681 return false; 681 return false;
682 } 682 }
683 virtual bool GetSavedMaximizedState(const std::wstring& window_name, 683 virtual bool GetSavedMaximizedState(const std::wstring& window_name,
684 bool* maximized) const { 684 bool* maximized) const {
685 return false; 685 return false;
686 } 686 }
687 virtual HICON GetDefaultWindowIcon() const { 687 virtual HICON GetDefaultWindowIcon() const {
688 return NULL; 688 return NULL;
689 } 689 }
690 virtual void AddRef() {}
691 virtual void ReleaseRef() {}
690 692
691 private: 693 private:
692 mutable scoped_ptr<Clipboard> clipboard_; 694 mutable scoped_ptr<Clipboard> clipboard_;
693 695
694 DISALLOW_COPY_AND_ASSIGN(TestViewsDelegate); 696 DISALLOW_COPY_AND_ASSIGN(TestViewsDelegate);
695 }; 697 };
696 698
697 // Tests that the Textfield view respond appropiately to cut/copy/paste. 699 // Tests that the Textfield view respond appropiately to cut/copy/paste.
698 TEST_F(ViewTest, TextfieldCutCopyPaste) { 700 TEST_F(ViewTest, TextfieldCutCopyPaste) {
699 views::ViewsDelegate::views_delegate = new TestViewsDelegate; 701 views::ViewsDelegate::views_delegate = new TestViewsDelegate;
(...skipping 639 matching lines...) Expand 10 before | Expand all | Expand 10 after
1339 } 1341 }
1340 1342
1341 TEST_F(ViewTest, ChangeNativeViewHierarchyChangeHierarchy) { 1343 TEST_F(ViewTest, ChangeNativeViewHierarchyChangeHierarchy) {
1342 // TODO(georgey): Fix the test for Linux 1344 // TODO(georgey): Fix the test for Linux
1343 #if defined(OS_WIN) 1345 #if defined(OS_WIN)
1344 TestChangeNativeViewHierarchy test(this); 1346 TestChangeNativeViewHierarchy test(this);
1345 test.CheckChangingHierarhy(); 1347 test.CheckChangingHierarhy();
1346 #endif 1348 #endif
1347 } 1349 }
1348 1350
OLDNEW
« no previous file with comments | « views/controls/menu/submenu_view.cc ('k') | views/views.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698