Issue 1664001: Fixes possible crash if the window hosting a menu was closed while the

Issue 1664001: Fixes possible crash if the window hosting a menu was closed while the (Closed)

Created:
10 years, 8 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Jay Civelli

CC:
chromium-reviews

Visibility:
Public.

Description

Fixes possible crash if the window hosting a menu was closed while the menu was showing. When this happens the window the menu creates is implicitly destroyed (because the parent is going away). BUG=25563 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44807

Patch Set 1 #

Patch Set 2 : Removed change to testing_profile #

Patch Set 3 : Removed unneeded methods and improved comments #

Total comments: 3

Patch Set 4 : Incorporated review feedback #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+445 lines, -206 lines)			Patch
M	chrome/browser/views/bookmark_bar_view.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/views/bookmark_bar_view_test.cc	View		9 chunks	+75 lines, -4 lines	0 comments	Download
M	chrome/browser/views/chrome_views_delegate.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/views/chrome_views_delegate.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	views/controls/button/menu_button.h	View	1 2 3	2 chunks	+5 lines, -1 line	0 comments	Download
M	views/controls/button/menu_button.cc	View	1 2 3	2 chunks	+14 lines, -1 line	0 comments	Download
M	views/controls/menu/menu_controller.h	View		3 chunks	+21 lines, -17 lines	0 comments	Download
M	views/controls/menu/menu_controller.cc	View		12 chunks	+22 lines, -10 lines	0 comments	Download
A	views/controls/menu/menu_host.h	View		1 chunk	+64 lines, -0 lines	0 comments	Download
M	views/controls/menu/menu_host_gtk.h	View	1 2	5 chunks	+21 lines, -16 lines	0 comments	Download
M	views/controls/menu/menu_host_gtk.cc	View	1 2	4 chunks	+73 lines, -59 lines	0 comments	Download
M	views/controls/menu/menu_host_root_view.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	views/controls/menu/menu_host_win.h	View	1 2	3 chunks	+26 lines, -20 lines	0 comments	Download
M	views/controls/menu/menu_host_win.cc	View	1 2 3	2 chunks	+67 lines, -54 lines	0 comments	Download
M	views/controls/menu/menu_item_view.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	views/controls/menu/submenu_view.h	View		3 chunks	+8 lines, -2 lines	0 comments	Download
M	views/controls/menu/submenu_view.cc	View	1 2	4 chunks	+16 lines, -16 lines	0 comments	Download
M	views/view_unittest.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	views/views.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	views/views_delegate.h	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	views/widget/widget_gtk.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jay Civelli

http://codereview.chromium.org/1664001/diff/5001/6006 File views/controls/button/menu_button.h (right): http://codereview.chromium.org/1664001/diff/5001/6006#newcode79 views/controls/button/menu_button.h:79: // Used to track if the menu was deleted ...

10 years, 8 months ago (2010-04-16 16:48:25 UTC) #2

sky

Updated http://codereview.chromium.org/1664001/diff/5001/6006 File views/controls/button/menu_button.h (right): http://codereview.chromium.org/1664001/diff/5001/6006#newcode79 views/controls/button/menu_button.h:79: // Used to track if the menu was ...

10 years, 8 months ago (2010-04-16 17:39:58 UTC) #3

LGTM

Expand Messages | Collapse Messages