Reenable ruby tests.

Reenable ruby tests.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44762

[antonm, 2010-04-16 09:07:36]

Jochen, Brett, Mike and Albert,

I am going to submit it.

Most probably it'd break Linux (dbg)(2) build---fast/ruby Layout tests.  In this
case I'd quickly revert it back.

The reason is troubles with those tests is not reproducible on my box and Linux
try bots, so thick it is, still it's a hope that those failures were just
flakiness.

[Nicolas Sylvain, 2010-04-16 14:08:39]

lg

On Fri, Apr 16, 2010 at 2:07 AM, <antonm@chromium.org> wrote:

> Reviewers: Nicolas Sylvain,
>
> Message:
> Jochen, Brett, Mike and Albert,
>
> I am going to submit it.
>
> Most probably it'd break Linux (dbg)(2) build---fast/ruby Layout tests.  In
> this
> case I'd quickly revert it back.
>
> The reason is troubles with those tests is not reproducible on my box and
> Linux
> try bots, so thick it is, still it's a hope that those failures were just
> flakiness.
>
> Description:
> Reenable ruby tests.
>
>
> Please review this at http://codereview.chromium.org/1662001/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     webkit/tools/layout_tests/test_expectations.txt
>
>
> Index: webkit/tools/layout_tests/test_expectations.txt
> ===================================================================
> --- webkit/tools/layout_tests/test_expectations.txt     (revision 44657)
> +++ webkit/tools/layout_tests/test_expectations.txt     (working copy)
> @@ -32,38 +32,3 @@
>  BUG40619 : media/video-seek-past-end-playing.html = PASS FAIL TIMEOUT
>  BUG40619 : media/video-seeking.html = PASS FAIL TIMEOUT
>
> -// New failing test after the webkit merge on 3/14/2010 by antonm
> -BUG41555 LINUX DEBUG : fast/ruby/parse-rp.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/ruby-empty-rt.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/ruby-illegal-1.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/ruby-illegal-2.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/ruby-illegal-3.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/ruby-illegal-4.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/ruby-illegal-5.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/ruby-illegal-6.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/ruby-illegal-7.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/ruby-illegal-combined.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/ruby-length.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/ruby-line-height.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/ruby-remove.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/ruby-run-break.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/ruby-runs-spans.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/ruby-runs.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/ruby-simple-rp.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/ruby-simple.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/ruby-text-indent.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/ruby-trailing.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/rubyDOM-insert-rt-block-1.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/rubyDOM-insert-rt-block-2.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/rubyDOM-insert-rt-block-3.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/rubyDOM-insert-rt.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/rubyDOM-insert-text1.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/rubyDOM-insert-text2.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/rubyDOM-insert-text3.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/rubyDOM-remove-rt-block-1.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/rubyDOM-remove-rt-block-2.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/rubyDOM-remove-rt-block-3.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/rubyDOM-remove-rt1.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/rubyDOM-remove-rt2.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/rubyDOM-remove-text1.html = CRASH
> -BUG41555 LINUX DEBUG : fast/ruby/rubyDOM-remove-text2.html = CRASH
>
>
>

[brettw, 2010-04-16 16:19:07]

LGTM