Issue 16594: Fix for issue 171:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16594: Fix for issue 171:... (Closed)

Created:
11 years, 11 months ago by iposva

Modified:
9 years, 4 months ago

Reviewers:
Feng Qian

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Fix for issue 171: - Make sure to not destroy the instance type by slightly rearranging the code. - Added regression test. Committed: http://code.google.com/p/v8/source/detail?r=1042

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -7 lines)			Patch
	M	src/stub-cache-arm.cc	View	1	2 chunks	+9 lines, -7 lines	0 comments	Download
	A	test/mjsunit/regress/regress-171.js	View		1 chunk	+41 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Feng Qian

11 years, 11 months ago (2009-01-07 23:11:36 UTC) #2

lgtm,

you may want to add a comment to the function that, the value of receiver
register might be destroyed.