chrome/browser/tab_contents/tab_contents.h - Issue 1656005: Fix password mgr heuristics for sites that keep the login form around after signin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/tab_contents.h

Issue 1656005: Fix password mgr heuristics for sites that keep the login form around after signin (Closed)

Patch Set: Responding to feedback Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/tab_contents/tab_contents.h

diff --git a/chrome/browser/tab_contents/tab_contents.h b/chrome/browser/tab_contents/tab_contents.h

index e50345562aa67da203be06f937edfb66cd788889..58460215acaae3232650b21ac8e35e29e8d54688 100644

--- a/chrome/browser/tab_contents/tab_contents.h

+++ b/chrome/browser/tab_contents/tab_contents.h

@@ -940,8 +940,10 @@ class TabContents : public PageNavigator,

virtual void ShowModalHTMLDialog(const GURL& url, int width, int height,

const std::string& json_arguments,

IPC::Message* reply_msg);

- virtual void PasswordFormsSeen(

+ virtual void PasswordFormsFound(

const std::vector<webkit_glue::PasswordForm>& forms);

+ virtual void PasswordFormsVisible(

+ const std::vector<webkit_glue::PasswordForm>& visible_forms);

virtual void PageHasOSDD(RenderViewHost* render_view_host,

int32 page_id, const GURL& url, bool autodetected);

virtual GURL GetAlternateErrorPageURL() const;