chrome/browser/renderer_host/render_view_host.h - Issue 1656005: Fix password mgr heuristics for sites that keep the login form around after signin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/render_view_host.h

Issue 1656005: Fix password mgr heuristics for sites that keep the login form around after signin (Closed)

Patch Set: Responding to feedback Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/renderer_host/render_view_host.h

diff --git a/chrome/browser/renderer_host/render_view_host.h b/chrome/browser/renderer_host/render_view_host.h

index 93c6158c1805a27ec09ec9a988ffc604fe0a3f49..61f82084bde8090a9b507f814a5a3b9a9d5944de 100644

--- a/chrome/browser/renderer_host/render_view_host.h

+++ b/chrome/browser/renderer_host/render_view_host.h

@@ -550,8 +550,10 @@ class RenderViewHost : public RenderWidgetHost {

IPC::Message* reply_msg);

void OnMsgFormsSeen(

const std::vector<webkit_glue::FormData>& forms);

- void OnMsgPasswordFormsSeen(

+ void OnMsgPasswordFormsFound(

const std::vector<webkit_glue::PasswordForm>& forms);

+ void OnMsgPasswordFormsVisible(

+ const std::vector<webkit_glue::PasswordForm>& visible_forms);

void OnMsgFormSubmitted(const webkit_glue::FormData& forms);

void OnMsgStartDragging(const WebDropData& drop_data,

WebKit::WebDragOperationsMask operations_allowed,