Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: chrome/browser/tab_contents/tab_contents.cc

Issue 1656005: Fix password mgr heuristics for sites that keep the login form around after signin (Closed)
Patch Set: Responding to feedback Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.h ('k') | chrome/common/render_messages_internal.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/tab_contents/tab_contents.h" 5 #include "chrome/browser/tab_contents/tab_contents.h"
6 6
7 #include "app/l10n_util.h" 7 #include "app/l10n_util.h"
8 #include "app/resource_bundle.h" 8 #include "app/resource_bundle.h"
9 #include "app/text_elider.h" 9 #include "app/text_elider.h"
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 2575 matching lines...) Expand 10 before | Expand all | Expand 10 after
2586 const std::string& json_arguments, 2586 const std::string& json_arguments,
2587 IPC::Message* reply_msg) { 2587 IPC::Message* reply_msg) {
2588 if (delegate()) { 2588 if (delegate()) {
2589 HtmlDialogUIDelegate* dialog_delegate = 2589 HtmlDialogUIDelegate* dialog_delegate =
2590 new ModalHtmlDialogDelegate(url, width, height, json_arguments, 2590 new ModalHtmlDialogDelegate(url, width, height, json_arguments,
2591 reply_msg, this); 2591 reply_msg, this);
2592 delegate()->ShowHtmlDialog(dialog_delegate, NULL); 2592 delegate()->ShowHtmlDialog(dialog_delegate, NULL);
2593 } 2593 }
2594 } 2594 }
2595 2595
2596 void TabContents::PasswordFormsSeen( 2596 void TabContents::PasswordFormsFound(
2597 const std::vector<webkit_glue::PasswordForm>& forms) { 2597 const std::vector<webkit_glue::PasswordForm>& forms) {
2598 GetPasswordManager()->PasswordFormsSeen(forms); 2598 GetPasswordManager()->PasswordFormsFound(forms);
2599 }
2600
2601 void TabContents::PasswordFormsVisible(
2602 const std::vector<webkit_glue::PasswordForm>& visible_forms) {
2603 GetPasswordManager()->PasswordFormsVisible(visible_forms);
2599 } 2604 }
2600 2605
2601 // Checks to see if we should generate a keyword based on the OSDD, and if 2606 // Checks to see if we should generate a keyword based on the OSDD, and if
2602 // necessary uses TemplateURLFetcher to download the OSDD and create a keyword. 2607 // necessary uses TemplateURLFetcher to download the OSDD and create a keyword.
2603 void TabContents::PageHasOSDD(RenderViewHost* render_view_host, 2608 void TabContents::PageHasOSDD(RenderViewHost* render_view_host,
2604 int32 page_id, const GURL& url, 2609 int32 page_id, const GURL& url,
2605 bool autodetected) { 2610 bool autodetected) {
2606 // Make sure page_id is the current page, and the TemplateURLModel is loaded. 2611 // Make sure page_id is the current page, and the TemplateURLModel is loaded.
2607 DCHECK(url.is_valid()); 2612 DCHECK(url.is_valid());
2608 if (!IsActiveEntry(page_id)) 2613 if (!IsActiveEntry(page_id))
(...skipping 531 matching lines...) Expand 10 before | Expand all | Expand 10 after
3140 } 3145 }
3141 3146
3142 Profile* TabContents::GetProfileForPasswordManager() { 3147 Profile* TabContents::GetProfileForPasswordManager() {
3143 return profile(); 3148 return profile();
3144 } 3149 }
3145 3150
3146 bool TabContents::DidLastPageLoadEncounterSSLErrors() { 3151 bool TabContents::DidLastPageLoadEncounterSSLErrors() {
3147 return controller().ssl_manager()->ProcessedSSLErrorFromRequest(); 3152 return controller().ssl_manager()->ProcessedSSLErrorFromRequest();
3148 } 3153 }
3149 3154
OLDNEW
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.h ('k') | chrome/common/render_messages_internal.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698