Chromium Code Reviews

Side by Side Diff: chrome/browser/renderer_host/render_view_host.cc

Issue 1656005: Fix password mgr heuristics for sites that keep the login form around after signin (Closed)
Patch Set: Responding to feedback Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/renderer_host/render_view_host.h" 5 #include "chrome/browser/renderer_host/render_view_host.h"
6 6
7 #include <string> 7 #include <string>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 745 matching lines...)
756 OnMsgGoToEntryAtOffset) 756 OnMsgGoToEntryAtOffset)
757 IPC_MESSAGE_HANDLER(ViewHostMsg_SetTooltipText, OnMsgSetTooltipText) 757 IPC_MESSAGE_HANDLER(ViewHostMsg_SetTooltipText, OnMsgSetTooltipText)
758 IPC_MESSAGE_HANDLER(ViewHostMsg_RunFileChooser, OnMsgRunFileChooser) 758 IPC_MESSAGE_HANDLER(ViewHostMsg_RunFileChooser, OnMsgRunFileChooser)
759 IPC_MESSAGE_HANDLER_DELAY_REPLY(ViewHostMsg_RunJavaScriptMessage, 759 IPC_MESSAGE_HANDLER_DELAY_REPLY(ViewHostMsg_RunJavaScriptMessage,
760 OnMsgRunJavaScriptMessage) 760 OnMsgRunJavaScriptMessage)
761 IPC_MESSAGE_HANDLER_DELAY_REPLY(ViewHostMsg_RunBeforeUnloadConfirm, 761 IPC_MESSAGE_HANDLER_DELAY_REPLY(ViewHostMsg_RunBeforeUnloadConfirm,
762 OnMsgRunBeforeUnloadConfirm) 762 OnMsgRunBeforeUnloadConfirm)
763 IPC_MESSAGE_HANDLER_DELAY_REPLY(ViewHostMsg_ShowModalHTMLDialog, 763 IPC_MESSAGE_HANDLER_DELAY_REPLY(ViewHostMsg_ShowModalHTMLDialog,
764 OnMsgShowModalHTMLDialog) 764 OnMsgShowModalHTMLDialog)
765 IPC_MESSAGE_HANDLER(ViewHostMsg_FormsSeen, OnMsgFormsSeen) 765 IPC_MESSAGE_HANDLER(ViewHostMsg_FormsSeen, OnMsgFormsSeen)
766 IPC_MESSAGE_HANDLER(ViewHostMsg_PasswordFormsSeen, OnMsgPasswordFormsSeen) 766 IPC_MESSAGE_HANDLER(ViewHostMsg_PasswordFormsFound, OnMsgPasswordFormsFound)
767 IPC_MESSAGE_HANDLER(ViewHostMsg_PasswordFormsVisible,
768 OnMsgPasswordFormsVisible)
767 IPC_MESSAGE_HANDLER(ViewHostMsg_FormSubmitted, OnMsgFormSubmitted) 769 IPC_MESSAGE_HANDLER(ViewHostMsg_FormSubmitted, OnMsgFormSubmitted)
768 IPC_MESSAGE_HANDLER(ViewHostMsg_StartDragging, OnMsgStartDragging) 770 IPC_MESSAGE_HANDLER(ViewHostMsg_StartDragging, OnMsgStartDragging)
769 IPC_MESSAGE_HANDLER(ViewHostMsg_UpdateDragCursor, OnUpdateDragCursor) 771 IPC_MESSAGE_HANDLER(ViewHostMsg_UpdateDragCursor, OnUpdateDragCursor)
770 IPC_MESSAGE_HANDLER(ViewHostMsg_TakeFocus, OnTakeFocus) 772 IPC_MESSAGE_HANDLER(ViewHostMsg_TakeFocus, OnTakeFocus)
771 IPC_MESSAGE_HANDLER(ViewHostMsg_PageHasOSDD, OnMsgPageHasOSDD) 773 IPC_MESSAGE_HANDLER(ViewHostMsg_PageHasOSDD, OnMsgPageHasOSDD)
772 IPC_MESSAGE_HANDLER(ViewHostMsg_DidGetPrintedPagesCount, 774 IPC_MESSAGE_HANDLER(ViewHostMsg_DidGetPrintedPagesCount,
773 OnDidGetPrintedPagesCount) 775 OnDidGetPrintedPagesCount)
774 IPC_MESSAGE_HANDLER(ViewHostMsg_DidPrintPage, DidPrintPage) 776 IPC_MESSAGE_HANDLER(ViewHostMsg_DidPrintPage, DidPrintPage)
775 IPC_MESSAGE_HANDLER(ViewHostMsg_AddMessageToConsole, OnAddMessageToConsole) 777 IPC_MESSAGE_HANDLER(ViewHostMsg_AddMessageToConsole, OnAddMessageToConsole)
776 IPC_MESSAGE_HANDLER(ViewHostMsg_ForwardToDevToolsAgent, 778 IPC_MESSAGE_HANDLER(ViewHostMsg_ForwardToDevToolsAgent,
(...skipping 573 matching lines...)
1350 Send(new ViewMsg_MediaPlayerActionAt(routing_id(), location, action)); 1352 Send(new ViewMsg_MediaPlayerActionAt(routing_id(), location, action));
1351 } 1353 }
1352 1354
1353 void RenderViewHost::OnMsgFormsSeen(const std::vector<FormData>& forms) { 1355 void RenderViewHost::OnMsgFormsSeen(const std::vector<FormData>& forms) {
1354 RenderViewHostDelegate::AutoFill* autofill_delegate = 1356 RenderViewHostDelegate::AutoFill* autofill_delegate =
1355 delegate_->GetAutoFillDelegate(); 1357 delegate_->GetAutoFillDelegate();
1356 if (autofill_delegate) 1358 if (autofill_delegate)
1357 autofill_delegate->FormsSeen(forms); 1359 autofill_delegate->FormsSeen(forms);
1358 } 1360 }
1359 1361
1360 void RenderViewHost::OnMsgPasswordFormsSeen( 1362 void RenderViewHost::OnMsgPasswordFormsFound(
1361 const std::vector<PasswordForm>& forms) { 1363 const std::vector<PasswordForm>& forms) {
1362 delegate_->PasswordFormsSeen(forms); 1364 delegate_->PasswordFormsFound(forms);
1365 }
1366
1367 void RenderViewHost::OnMsgPasswordFormsVisible(
1368 const std::vector<PasswordForm>& visible_forms) {
1369 delegate_->PasswordFormsVisible(visible_forms);
1363 } 1370 }
1364 1371
1365 void RenderViewHost::OnMsgFormSubmitted(const FormData& form) { 1372 void RenderViewHost::OnMsgFormSubmitted(const FormData& form) {
1366 RenderViewHostDelegate::Autocomplete* autocomplete_delegate = 1373 RenderViewHostDelegate::Autocomplete* autocomplete_delegate =
1367 delegate_->GetAutocompleteDelegate(); 1374 delegate_->GetAutocompleteDelegate();
1368 if (autocomplete_delegate) 1375 if (autocomplete_delegate)
1369 autocomplete_delegate->FormSubmitted(form); 1376 autocomplete_delegate->FormSubmitted(form);
1370 1377
1371 RenderViewHostDelegate::AutoFill* autofill_delegate = 1378 RenderViewHostDelegate::AutoFill* autofill_delegate =
1372 delegate_->GetAutoFillDelegate(); 1379 delegate_->GetAutoFillDelegate();
(...skipping 485 matching lines...)
1858 integration_delegate->OnPageTranslated(page_id, original_lang, 1865 integration_delegate->OnPageTranslated(page_id, original_lang,
1859 translated_lang, error_type); 1866 translated_lang, error_type);
1860 } 1867 }
1861 1868
1862 void RenderViewHost::OnContentBlocked(ContentSettingsType type) { 1869 void RenderViewHost::OnContentBlocked(ContentSettingsType type) {
1863 RenderViewHostDelegate::Resource* resource_delegate = 1870 RenderViewHostDelegate::Resource* resource_delegate =
1864 delegate_->GetResourceDelegate(); 1871 delegate_->GetResourceDelegate();
1865 if (resource_delegate) 1872 if (resource_delegate)
1866 resource_delegate->OnContentBlocked(type); 1873 resource_delegate->OnContentBlocked(type);
1867 } 1874 }
OLDNEW
« no previous file with comments | « chrome/browser/renderer_host/render_view_host.h ('k') | chrome/browser/renderer_host/render_view_host_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine