Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Side by Side Diff: chrome/browser/password_manager/password_manager.h

Issue 1656005: Fix password mgr heuristics for sites that keep the login form around after signin (Closed)
Patch Set: Responding to feedback Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/login_prompt.cc ('k') | chrome/browser/password_manager/password_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_
7 7
8 #include "base/scoped_ptr.h" 8 #include "base/scoped_ptr.h"
9 #include "base/stl_util-inl.h" 9 #include "base/stl_util-inl.h"
10 #include "chrome/browser/login_model.h" 10 #include "chrome/browser/login_model.h"
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 // Notification that the user navigated away from the current page. 64 // Notification that the user navigated away from the current page.
65 // Unless this is a password form submission, for our purposes this 65 // Unless this is a password form submission, for our purposes this
66 // means we're done with the current page, so we can clean-up. 66 // means we're done with the current page, so we can clean-up.
67 void DidNavigate(); 67 void DidNavigate();
68 68
69 // Show a prompt to save submitted password if it is a new username for 69 // Show a prompt to save submitted password if it is a new username for
70 // the form, or else just update the stored value. 70 // the form, or else just update the stored value.
71 void DidStopLoading(); 71 void DidStopLoading();
72 72
73 // Notifies the password manager that password forms were parsed on the page. 73 // Notifies the password manager that password forms were parsed on the page.
74 void PasswordFormsSeen(const std::vector<webkit_glue::PasswordForm>& forms); 74 void PasswordFormsFound(const std::vector<webkit_glue::PasswordForm>& forms);
75
76 // Notifies the password manager which password forms are initially visible.
77 void PasswordFormsVisible(
78 const std::vector<webkit_glue::PasswordForm>& visible_forms);
75 79
76 // When a form is submitted, we prepare to save the password but wait 80 // When a form is submitted, we prepare to save the password but wait
77 // until we decide the user has successfully logged in. This is step 1 81 // until we decide the user has successfully logged in. This is step 1
78 // of 2 (see SavePassword). 82 // of 2 (see SavePassword).
79 void ProvisionallySavePassword(webkit_glue::PasswordForm form); 83 void ProvisionallySavePassword(webkit_glue::PasswordForm form);
80 84
81 // Clear any pending saves 85 // Clear any pending saves
82 void ClearProvisionalSave(); 86 void ClearProvisionalSave();
83 87
84 // LoginModel implementation. 88 // LoginModel implementation.
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 LoginModelObserver* observer_; 127 LoginModelObserver* observer_;
124 128
125 // Set to false to disable the password manager (will no longer fill 129 // Set to false to disable the password manager (will no longer fill
126 // passwords or ask you if you want to save passwords). 130 // passwords or ask you if you want to save passwords).
127 BooleanPrefMember password_manager_enabled_; 131 BooleanPrefMember password_manager_enabled_;
128 132
129 DISALLOW_EVIL_CONSTRUCTORS(PasswordManager); 133 DISALLOW_EVIL_CONSTRUCTORS(PasswordManager);
130 }; 134 };
131 135
132 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_ 136 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_
OLDNEW
« no previous file with comments | « chrome/browser/login_prompt.cc ('k') | chrome/browser/password_manager/password_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698