Issue 165543: Revert "Reverting 23406" as it didn't break any tests....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165543: Revert "Reverting 23406" as it didn't break any tests.... (Closed)

Created:
11 years, 4 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
levin

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Revert "Reverting 23406" as it didn't break any tests. Change PluginInstallImpl to use base::WindowImpl instead of CWindowImpl to reduce a dependency on ATL. BUG=5023 TEST=Uninstall flash. Visit hulu.com and install the flash plugin. Original review: http://codereview.chromium.org/165469 TBR=levin

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -110 lines)			Patch
M	base/window_impl.h	View	3 chunks	+20 lines, -14 lines	0 comments	Download
M	base/window_impl.cc	View	3 chunks	+4 lines, -14 lines	0 comments	Download
M	chrome/browser/views/tab_contents/tab_contents_view_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/widget/widget_win.cc	View	20 chunks	+33 lines, -33 lines	0 comments	Download
M	webkit/default_plugin/default_plugin.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/default_plugin/plugin_impl_win.h	View	5 chunks	+4 lines, -6 lines	0 comments	Download
M	webkit/default_plugin/plugin_impl_win.cc	View	16 chunks	+39 lines, -36 lines	0 comments	Download
M	webkit/tools/test_shell/foreground_helper.h	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	webkit/webkit.gyp	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages