Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Side by Side Diff: src/ia32/codegen-ia32.h

Issue 165527: Refactor SetFunctionInfo to reduce long argument list (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/compiler.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 // be called by compiler.cc. 292 // be called by compiler.cc.
293 static Handle<Code> MakeCode(FunctionLiteral* fun, 293 static Handle<Code> MakeCode(FunctionLiteral* fun,
294 Handle<Script> script, 294 Handle<Script> script,
295 bool is_eval); 295 bool is_eval);
296 296
297 #ifdef ENABLE_LOGGING_AND_PROFILING 297 #ifdef ENABLE_LOGGING_AND_PROFILING
298 static bool ShouldGenerateLog(Expression* type); 298 static bool ShouldGenerateLog(Expression* type);
299 #endif 299 #endif
300 300
301 static void SetFunctionInfo(Handle<JSFunction> fun, 301 static void SetFunctionInfo(Handle<JSFunction> fun,
302 int length, 302 FunctionLiteral* lit,
303 int function_token_position,
304 int start_position,
305 int end_position,
306 bool is_expression,
307 bool is_toplevel, 303 bool is_toplevel,
308 Handle<Script> script, 304 Handle<Script> script);
309 Handle<String> inferred_name);
310 305
311 // Accessors 306 // Accessors
312 MacroAssembler* masm() { return masm_; } 307 MacroAssembler* masm() { return masm_; }
313 308
314 VirtualFrame* frame() const { return frame_; } 309 VirtualFrame* frame() const { return frame_; }
315 310
316 bool has_valid_frame() const { return frame_ != NULL; } 311 bool has_valid_frame() const { return frame_ != NULL; }
317 312
318 // Set the virtual frame to be new_frame, with non-frame register 313 // Set the virtual frame to be new_frame, with non-frame register
319 // reference counts given by non_frame_registers. The non-frame 314 // reference counts given by non_frame_registers. The non-frame
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
656 | ModeBits::encode(mode_) 651 | ModeBits::encode(mode_)
657 | FlagBits::encode(flags_); 652 | FlagBits::encode(flags_);
658 } 653 }
659 void Generate(MacroAssembler* masm); 654 void Generate(MacroAssembler* masm);
660 }; 655 };
661 656
662 657
663 } } // namespace v8::internal 658 } } // namespace v8::internal
664 659
665 #endif // V8_IA32_CODEGEN_IA32_H_ 660 #endif // V8_IA32_CODEGEN_IA32_H_
OLDNEW
« no previous file with comments | « src/compiler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698