Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1655: Fix IDNtoUnicode and unittest. ... (Closed)

Created:
12 years, 3 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com, reima
Visibility:
Public.

Description

Fix IDNtoUnicode and unittest. 1. Check whether uloc_getdata returns the default locale because an invalid or unsupported (not a part of ICU data file we use) locale is passed. 2. Replace 'se' with 'sv' in IDNToUnicode test and change the corresponding test result to true. U+00C4 IS used in Swedish, but the result was set to false because the test results were machine generated with the same typo ('se' in place of 'sv') under en_US.UTF-8 locale on Linux and we ran this test only on Windows with en_US locale. 1st part of patch is by Matthias Reitinger <reimarvin@gmail.com>; BUG=1153 TEST=NetUtilTest.IDNToUnicode passes in various locales, C, en_US, en_US.utf8, ja_JP.utf8, sv_SE.utf8, hi_IN.utf8, ru_RU.utf8, fr_CA Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2052

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/net_util.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M net/base/net_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jungshik at Google
Once reimarvin signs the contributor form (with his name), I'll add him to AUTHORS file.
12 years, 3 months ago (2008-09-09 05:40:36 UTC) #1
Evan Martin
LGTM http://codereview.chromium.org/1655/diff/4/203 File net/base/net_util.cc (right): http://codereview.chromium.org/1655/diff/4/203#newcode544 Line 544: // TODO(jungshik) Turn this check on when ...
12 years, 3 months ago (2008-09-09 20:56:46 UTC) #2
jungshik at Google
12 years, 3 months ago (2008-09-11 03:12:33 UTC) #3
On 2008/09/09 20:56:46, Evan Martin wrote:
> LGTM
> 
> http://codereview.chromium.org/1655/diff/4/203
> File net/base/net_util.cc (right):
> 
> http://codereview.chromium.org/1655/diff/4/203#newcode544
> Line 544: // TODO(jungshik) Turn this check on when the ICU data file is
> Is there a bug on this somewhere?  Seems like it'd be easy to lose...

There's an internal bug filed on that. I'll refile it here.

Powered by Google App Engine
This is Rietveld 408576698