Issue 165495: Updating hammer script based on review suggestions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165495: Updating hammer script based on review suggestions. (Closed)

Created:
11 years, 4 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Randall Spangler, sgk

CC:
chromium-reviews_googlegroups.com, M-A Ruel

Base URL:
svn://chrome-svn/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Updating hammer script based on review suggestions. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23440

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	hammer	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bradn

So I had some feedback on the style for this shell script (did this test ...

11 years, 4 months ago (2009-08-13 21:59:46 UTC) #1

sgk

11 years, 4 months ago (2009-08-13 22:08:13 UTC) #2

lgtm

The '[' works in old-style sh (it's usually a link to the 'test' program) so
that should be fine everywhere.  The part that I really didn't care for was the
[[, which is bash-specific.

Expand Messages | Collapse Messages