Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Unified Diff: net/base/tcp_client_socket_unittest.cc

Issue 16549: Add an easy way to do a synchronous connect from test code. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/base/tcp_client_socket.h ('K') | « net/base/tcp_client_socket.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/tcp_client_socket_unittest.cc
===================================================================
--- net/base/tcp_client_socket_unittest.cc (revision 7611)
+++ net/base/tcp_client_socket_unittest.cc (working copy)
@@ -49,6 +49,22 @@
EXPECT_FALSE(sock.IsConnected());
}
+TEST_F(TCPClientSocketTest, SyncConnect) {
+ net::AddressList addr;
+ net::HostResolver resolver;
+
+ int rv = resolver.Resolve("www.google.com", 80, &addr, NULL);
+ EXPECT_EQ(rv, net::OK);
+
+ net::TCPClientSocket sock(addr);
+
+ EXPECT_FALSE(sock.IsConnected());
+
+ rv = net::TCPClientSocketSyncConnector::Connect(&sock);
+ EXPECT_EQ(rv, net::OK);
+ EXPECT_TRUE(sock.IsConnected());
+}
+
TEST_F(TCPClientSocketTest, Read) {
net::AddressList addr;
net::HostResolver resolver;
« net/base/tcp_client_socket.h ('K') | « net/base/tcp_client_socket.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698