Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 165461: Mac -fno-threadsafe-statics (Closed)

Created:
11 years, 4 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
stuartmorgan, TVL
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Use -fno-threadsafe-statics to disable thread-safe static semantics in C++. This will eliminate the cxa_guard_acquire/release locks around static guard accesses. The Windows compiler doesn't support thread-safe statics at all, so none of our cross-platform code relies on thread safety. We are using -fno-threadsafe-statics on Linux as well, since r20616. It's likely that threading is not a concern in most to all Mac-specific code using statics. BUG=16713 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23326

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M build/common.gypi View 4 chunks +20 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
Unless someone volunteers to audit the use of statics in Mac-specific code, I think we ...
11 years, 4 months ago (2009-08-13 16:20:45 UTC) #1
Mark Mentovai
TVL is mostly unreachable today, let's try Stuart.
11 years, 4 months ago (2009-08-13 17:57:35 UTC) #2
stuartmorgan
11 years, 4 months ago (2009-08-13 18:03:14 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698