Butcher some files to make ui_tests run 0 tests on Linux.

Butcher some files to make ui_tests run 0 tests on Linux.

[Evan Martin, 2009-01-06 19:32:39]

Your wish is my command!

[Evan Martin, 2009-01-06 19:37:51]

+pawel, since he does this sort of thing a lot (I was blown away by how much of
chrome/ builds already)

[Paweł Hajdan Jr., 2009-01-06 20:08:08]

Next nice scons file to port some files.

I would prefer a //TODO(port) with good explanation (or just "Port me" in
trivial cases) in many places where NOTIMPLEMENTED() is used and we will
generally rather want to remove the #ifdefs than change the code inside them.
But this is just a suggestion.

http://codereview.chromium.org/16545/diff/1/3
File chrome/test/ui/ui_test.cc (right):

http://codereview.chromium.org/16545/diff/1/3#newcode110
Line 110: NOTIMPLEMENTED();
You probably meant to put NOTIMPLEMENTED() in the #else part.

http://codereview.chromium.org/16545/diff/1/3#newcode159
Line 159: NOTIMPLEMENTED();
Please add a TODO(port) here explaining what needs to be ported to enable this.

http://codereview.chromium.org/16545/diff/1/4
File chrome/test/ui/ui_test.h (right):

http://codereview.chromium.org/16545/diff/1/4#newcode365
Line 365: NOTREACHED();
It feels more like NOTIMPLEMENTED to me. I would also add TODO(port) to make it
more easily greppable.

http://codereview.chromium.org/16545/diff/1/4#newcode414
Line 414: // TODO(port): restore me.
I would add "when x is ported", where x probably means something related to
files and their mtime. Again, it's rather a suggestion, but more detailed info
encourages more detailed look when scanning output of git grep TODO(port).

[M-A Ruel, 2009-01-06 20:12:54]

lgtm with Pawel changes.

http://codereview.chromium.org/16545/diff/1/3
File chrome/test/ui/ui_test.cc (right):

http://codereview.chromium.org/16545/diff/1/3#newcode43
Line 43: // Delay to let the browser complete the test.
alignment

[Evan Martin, 2009-01-06 20:31:44]

Ok, I added comments next to every NOTIMPLEMENTED with a brief description of
why I commented it out.