Issue 165448: - Added simple memory reduction behavior for IdleNotification....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165448: - Added simple memory reduction behavior for IdleNotification.... (Closed)

Created:
11 years, 4 months ago by bak

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- Added simple memory reduction behavior for IdleNotification. - This also include a one line change approved by lrh. http://codereview.chromium.org/164469 Committed: http://code.google.com/p/v8/source/detail?r=2677

Patch Set 1 #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -2 lines)			Patch
M	src/flag-definitions.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/heap.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/heap.cc	View	2 chunks	+15 lines, -1 line	0 comments	Download
M	src/spaces.h	View	4 chunks	+24 lines, -0 lines	1 comment	Download
M	src/v8.cc	View	1 chunk	+6 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/165448/diff/1/3 File src/spaces.h (right): http://codereview.chromium.org/165448/diff/1/3#newcode372 Line 372: // start is not NULL, the size ...

11 years, 4 months ago (2009-08-13 12:00:56 UTC) #2

Kasper Lund

http://codereview.chromium.org/165448/diff/1/5 File src/v8.cc (right): http://codereview.chromium.org/165448/diff/1/5#newcode158 Line 158: Two newlines between function definitions?

11 years, 4 months ago (2009-08-20 07:20:25 UTC) #3

Mads Ager (chromium)

11 years, 4 months ago (2009-08-20 07:54:38 UTC) #4

On 2009/08/20 07:20:25, Kasper Lund wrote:
> http://codereview.chromium.org/165448/diff/1/5
> File src/v8.cc (right):
> 
> http://codereview.chromium.org/165448/diff/1/5#newcode158
> Line 158: 
> Two newlines between function definitions?

I will fix this one.

Expand Messages | Collapse Messages