Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 16539: Factored the generation of JSON serialization from beeing part of the mirror ... (Closed)

Created:
11 years, 11 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Factored the generation of JSON serialization from beeing part of the mirror objects into a seperate class. The purpose of this is to make it easier to change the serialization to contain object identification and references. Added a test case for the script mirror and modified a number of the other mirror tests. Committed: http://code.google.com/p/v8/source/detail?r=1035

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -243 lines) Patch
M src/mirror-delay.js View 1 18 chunks +262 lines, -235 lines 0 comments Download
M test/mjsunit/mirror-array.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/mirror-function.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/mirror-object.js View 2 chunks +6 lines, -1 line 0 comments Download
A test/mjsunit/mirror-script.js View 1 chunk +70 lines, -0 lines 0 comments Download
M test/mjsunit/mirror-string.js View 3 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years, 11 months ago (2009-01-06 15:51:53 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/16539/diff/1/7 File src/mirror-delay.js (right): http://codereview.chromium.org/16539/diff/1/7#newcode1713 Line 1713: StringToJSON_(mirror.className()))); Indent since this is argument to ...
11 years, 11 months ago (2009-01-07 09:10:25 UTC) #2
Søren Thygesen Gjesse
11 years, 11 months ago (2009-01-07 09:17:56 UTC) #3
http://codereview.chromium.org/16539/diff/1/7
File src/mirror-delay.js (right):

http://codereview.chromium.org/16539/diff/1/7#newcode1713
Line 1713: StringToJSON_(mirror.className())));
On 2009/01/07 09:10:25, Mads Ager wrote:
> Indent since this is argument to MakeJSONPair and not to push.

Done.

Powered by Google App Engine
This is Rietveld 408576698