Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5474)

Unified Diff: chrome/browser/download/download_file.h

Issue 16533: Convert download manager to FilePath. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/automation/automation_provider.cc ('k') | chrome/browser/download/download_file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_file.h
===================================================================
--- chrome/browser/download/download_file.h (revision 7599)
+++ chrome/browser/download/download_file.h (working copy)
@@ -53,6 +53,7 @@
#include "chrome/browser/history/download_types.h"
class DownloadManager;
+class FilePath;
class GURL;
class MessageLoop;
class ResourceDispatcherHost;
@@ -93,12 +94,12 @@
void Cancel();
// Rename the download file. Returns 'true' if the rename was successful.
- bool Rename(const std::wstring& full_path);
+ bool Rename(const FilePath& full_path);
// Accessors.
int64 bytes_so_far() const { return bytes_so_far_; }
int id() const { return id_; }
- std::wstring full_path() const { return full_path_; }
+ FilePath full_path() const { return full_path_; }
int render_process_id() const { return render_process_id_; }
int render_view_id() const { return render_view_id_; }
int request_id() const { return request_id_; }
@@ -132,7 +133,7 @@
int64 bytes_so_far_;
// Full path to the downloaded file.
- std::wstring full_path_;
+ FilePath full_path_;
// Whether the download is still using its initial temporary path.
bool path_renamed_;
@@ -192,27 +193,23 @@
void RemoveDownload(int id, DownloadManager* manager);
// Handler for shell operations sent from the UI to the download thread.
- void OnShowDownloadInShell(const std::wstring full_path);
+ void OnShowDownloadInShell(const FilePath& full_path);
// Handler to open or execute a downloaded file.
- void OnOpenDownloadInShell(const std::wstring full_path,
+ void OnOpenDownloadInShell(const FilePath& full_path,
const std::wstring& url, HWND parent_window);
// The download manager has provided a final name for a download. Sent from
// the UI thread and run on the download thread.
- void OnFinalDownloadName(int id, const std::wstring& full_path);
+ void OnFinalDownloadName(int id, const FilePath& full_path);
// Timer notifications.
void UpdateInProgressDownloads();
MessageLoop* file_loop() const { return file_loop_; }
- // Called by the download manager at initialization to ensure the default
- // download directory exists.
- void CreateDirectory(const std::wstring& directory);
+ // Called by the download manager to delete non validated dangerous downloads.
+ static void DeleteFile(const FilePath& path);
- // Called by the donwload manager to delete non validated dangerous downloads.
- void DeleteFile(const std::wstring& path);
-
private:
// Timer helpers for updating the UI about the current progress of a download.
void StartUpdateTimer();
« no previous file with comments | « chrome/browser/automation/automation_provider.cc ('k') | chrome/browser/download/download_file.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698