Convert download manager to FilePath.

Convert download manager to FilePath.

(Fixed up version of issue 17032. Now passes all unit tests.)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7630

[Evan Stade, 2009-01-06 18:53:48]

Somehow I managed to miss a failing unit test the last time around with this
patch. I fixed the problem, and the majority of the patch is the same.

see http://codereview.chromium.org/17032/

[brettw, 2009-01-06 19:11:38]

http://codereview.chromium.org/16533/diff/401/602
File base/file_util.cc (right):

http://codereview.chromium.org/16533/diff/401/602#newcode380
Line 380: GetFileExtensionFromPath(FilePath::FromWStringHack(path));
Indent this 2 more spaces.

http://codereview.chromium.org/16533/diff/401/614
File chrome/browser/download/download_file.cc (right):

http://codereview.chromium.org/16533/diff/401/614#newcode99
Line 99: full_path_.value().c_str(), new_path.value().c_str())) {
I think the .c_str() calls are wrong here (looks like they were in the old code,
too, since they got automatically converted back to wstrings). Can this function
just take FilePaths?

http://codereview.chromium.org/16533/diff/401/614#newcode132
Line 132: win_util::SetInternetZoneIdentifier(full_path_.value());
Can you just change the function to take a FilePath instead? Looks like there
are only 2 callers and you had to change both calls anyway.

http://codereview.chromium.org/16533/diff/401/614#newcode528
Line 528: win_util::SaferOpenItemViaShell(parent_window, L"", full_path.value(),
Can you change this to take a FilePath as well? It looks like this is the only
caller.

http://codereview.chromium.org/16533/diff/401/614#newcode531
Line 531: win_util::OpenItemViaShell(full_path.value(), true);
Ditto

http://codereview.chromium.org/16533/diff/401/611
File chrome/browser/download/download_manager.cc (right):

http://codereview.chromium.org/16533/diff/401/611#newcode1053
Line 1053: const std::string& mime_type, FilePath::StringType*
generated_extension) {
The args should line up. If you can't fit them, move them all to separate lines
indented 4 spaces.

[Evan Stade, 2009-01-06 19:38:20]

updated.

[brettw, 2009-01-06 19:40:13]

LGTM

[Evan Stade, 2009-01-06 20:13:23]

Updated to sync with Tony's changes.

[brettw, 2009-01-06 20:17:11]

LGTM